Remove locale dependent FileSystemException check #21633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fin SourceFile, files that do not exist are expected and related exceptions
should be ignored. There are two relevant cases:
scala> java.nio.file.Files.newInputStream(java.nio.file.FileSystems.getDefault().getPath("does-not-exist"))
java.nio.file.NoSuchFileException: does-not-exist
scala> java.nio.file.Files.newInputStream(java.nio.file.FileSystems.getDefault().getPath("regular-file-instead-of-directory/filename"))
java.nio.file.FileSystemException: regular-file-instead-of-directory/filename: Not a directory
Ideally, other I/O errors would be propagated to the caller.
However, there is no reliable way to distinguish them based on the
exceptions alone. In particular, the message cannot be checked, because
it depends on the operating system and it is localized.
Revert the addition of the check and just accept this.
niklasf
force-pushed
the
locale-dependent-fse
branch
from
6517f04
to
aa91e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SourceFile, files that do not exist are expected and related exceptions should be ignored. There are two relevant cases:
Ideally, other I/O errors would be propagated to the caller.
However, there is no reliable way to distinguish them based on the exceptions alone. In particular, the message cannot be checked, because it depends on the operating system and it is localized.
Revert the addition of the check and just accept this.
Resolves the following concrete bug:
LANGUAGE=fr sbt compilejava.nio.file.FileSystemException: lila/src/main/scala/future.scala: N'est pas un dossier(stacktrace)Not sure how to exercise locale dependent issues in a unit test.
cc @som-snytt in case I misinterpreted 159da44 and distinguishing other I/O errors is not optional.